From b70fd48babbe8348bee8b4a5f28ef1a49eaa63d3 Mon Sep 17 00:00:00 2001 From: Luke Tomlinson Date: Thu, 20 May 2021 12:31:02 -0400 Subject: [PATCH] Modify tests to not rely on buffer size, but only test larger output --- packages/exec/__tests__/exec.test.ts | 10 ++-------- packages/exec/__tests__/scripts/stdoutoutputlarge.js | 2 +- 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/packages/exec/__tests__/exec.test.ts b/packages/exec/__tests__/exec.test.ts index 05e3786f0a..1d92dec040 100644 --- a/packages/exec/__tests__/exec.test.ts +++ b/packages/exec/__tests__/exec.test.ts @@ -679,7 +679,6 @@ describe('@actions/exec', () => { 'stdoutoutput.js' ) - let numberOfBuffers = 0 const nodePath: string = await io.which('node', true) let listenerOut = '' @@ -691,7 +690,6 @@ describe('@actions/exec', () => { listeners: { stdout: data => { listenerOut = data.toString() - numberOfBuffers += 1 } } } @@ -700,7 +698,6 @@ describe('@actions/exec', () => { expect(exitCodeOut).toBe(0) expect(stdout).toBe('this is output to stdout') expect(listenerOut).toBe('this is output to stdout') - expect(numberOfBuffers).toBe(1) let listenerErr = '' const {exitCode: exitCodeErr, stderr} = await exec.getExecOutput( @@ -732,7 +729,6 @@ describe('@actions/exec', () => { 'stdoutoutputlarge.js' ) - let numFullBuffers = 0 const nodePath: string = await io.which('node', true) let listenerOut = '' @@ -743,7 +739,6 @@ describe('@actions/exec', () => { ...getExecOptions(), listeners: { stdout: data => { - numFullBuffers += 1 listenerOut += data.toString() } } @@ -751,9 +746,8 @@ describe('@actions/exec', () => { ) expect(exitCodeOut).toBe(0) - expect(Buffer.byteLength(stdout || '', 'utf8')).toBe(2 ** 32) - expect(Buffer.byteLength(listenerOut, 'utf8')).toBe(2 ** 32) - expect(numFullBuffers).toBeGreaterThan(1) + expect(Buffer.byteLength(stdout || '', 'utf8')).toBe(2 ** 24) + expect(Buffer.byteLength(listenerOut, 'utf8')).toBe(2 ** 24) let listenerErr = '' const {exitCode: exitCodeErr, stderr} = await exec.getExecOutput( diff --git a/packages/exec/__tests__/scripts/stdoutoutputlarge.js b/packages/exec/__tests__/scripts/stdoutoutputlarge.js index 27922e878a..e31635ce80 100644 --- a/packages/exec/__tests__/scripts/stdoutoutputlarge.js +++ b/packages/exec/__tests__/scripts/stdoutoutputlarge.js @@ -1,3 +1,3 @@ //Default highWaterMark for readable stream buffers us 64K (2^16) //so we go over that to get more than a buffer's worth -process.stdout.write('a'.repeat(2**32)); +process.stdout.write('a'.repeat(2**24));