Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pages/static.yml: What does the "Setup Pages" step achieve? #1996

Closed
andreasabel opened this issue Apr 1, 2023 · 4 comments
Closed

pages/static.yml: What does the "Setup Pages" step achieve? #1996

andreasabel opened this issue Apr 1, 2023 · 4 comments
Labels
pages Related to workflows that show on the GitHub Pages settings page

Comments

@andreasabel
Copy link

The workflow template to deploy a static web page contains an actions/configure-pages step:

- name: Setup Pages
uses: actions/configure-pages@v3

Does this step achieve anything for static pages?

  • If yes, please document why it is necessary or useful.
  • If no, please remove.
@github-actions
Copy link

github-actions bot commented Jul 1, 2023

This issue has become stale and will be closed automatically within a period of time. Sorry about that.

@andreasabel
Copy link
Author

It is not my fault that this issue has become stale. I am still waiting for a response.

@yoannchaudet
Copy link
Contributor

You can learn more about this step in https://github.com/actions/configure-pages#configure-pages.

It enable Pages if needed, extract metadata (e.g. the URL to access your Pages site) and does automatic configuration (related to base path) for some static site generators (nuxt, next, gatsby, sveltekit).

If we document it in the starter workflows, it means we believe it is useful for most people. It is open source and if you disagree with the usefulness of the step, don't hesitate to remove it from your own workflows.

@JamesMGreene
Copy link
Contributor

It's fair to say that, in this case, it likely isn't doing anything for most folks with a static site. 🤔

We've left it in as it is potentially still useful if you decide you want to expand what the starter workflow does once you've added it to your own repository. However, it might be reasonable to comment it out as a step and just leave a note about why you may want to use it. 🤷🏻

Would be open to a PR to that effect, or, as Yoann mentioned, you can feel free to remove it from your own workflows as well. 👍🏻

@JamesMGreene JamesMGreene added the pages Related to workflows that show on the GitHub Pages settings page label Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pages Related to workflows that show on the GitHub Pages settings page
Projects
None yet
Development

No branches or pull requests

3 participants