Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug with some logs regarding the updates and comments #503

Closed
C0ZEN opened this issue Jun 14, 2021 · 0 comments
Closed

Bug with some logs regarding the updates and comments #503

C0ZEN opened this issue Jun 14, 2021 · 0 comments

Comments

@C0ZEN
Copy link
Contributor

C0ZEN commented Jun 14, 2021

@MAGICCC there is bad condition on the logger on the PR I provided sadly 🐛

if (shouldRemoveStaleWhenUpdated) {
issueLogger.info(
`The stale label should not be removed due to an update`
);
} else {
issueLogger.info(
`The stale label should be removed if all conditions met`
);
}

FYI, I do not test the logs 😞

So, the correct logs should be:

  [#5] Issue has been updated: true
  [#5] The option remove-stale-when-updated (​https://github.com/actions/stale#remove-stale-when-updated​) is: true
  [#5] The stale label should be removed if all conditions met
  [#5] The option remove-stale-when-commented (​https://github.com/actions/stale#remove-stale-when-commented​) is: true
  [#5] The stale label should be removed if all conditions met
  [#5] Remove the stale label since the issue has an update and the workflow should remove the stale label when updated
  [#5] The issue is no longer stale. Removing the stale label...
  [#5] Removing the label "stale" from this issue...
  [#5] The label "stale" was removed
  [#5] Skipping the process since the issue is now un-stale
  [#5] 4 operations consumed for this issue

See #441 (comment)

@C0ZEN C0ZEN changed the title Fix some bad logs Bug with some logs regarding the updates and comments Jun 14, 2021
C0ZEN added a commit to C0ZEN/stale that referenced this issue Jun 14, 2021
@C0ZEN C0ZEN closed this as completed Jun 15, 2021
C0ZEN added a commit to C0ZEN/stale that referenced this issue Jun 18, 2021
C0ZEN added a commit to C0ZEN/stale that referenced this issue Jun 24, 2021
C0ZEN added a commit to C0ZEN/stale that referenced this issue Jul 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant