Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(options): add new options to avoid stale base on comments #494

Merged
merged 3 commits into from Jun 14, 2021

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented Jun 7, 2021

Changes

  • Add 3 new options to avoid staling when a comment is added
  • The scope of remove-stale-when-updated will be reduced resulting in a breaking change (@luketomlinson for the release notes!) when using the option at false

⚠️ this is a breaking change

Context

Helping to close (maybe) #441, #470, #435?
Closes #390 due to no activity

@C0ZEN C0ZEN requested a review from a team as a code owner June 7, 2021 20:08
@C0ZEN C0ZEN changed the title feat(options): add new options to avoid stale based on comments feat(options): add new options to avoid stale base on comments Jun 7, 2021
README.md Outdated Show resolved Hide resolved
@C0ZEN C0ZEN force-pushed the feature/remove-stale-when-commented branch from 3502077 to 7ae2ace Compare June 8, 2021 16:46
@C0ZEN
Copy link
Contributor Author

C0ZEN commented Jun 8, 2021

@luketomlinson ready as well FYI

Helping to close actions#441, actions#470, actions#435?
Closes actions#390 due to no activity

BREAKING CHANGES: the options related to remove-stale-when-updated will only check the updates, not the comment. It is only impactint the configurations using the value at false
@C0ZEN C0ZEN force-pushed the feature/remove-stale-when-commented branch from ff07a00 to 09d1712 Compare June 10, 2021 18:11
@luketomlinson luketomlinson merged commit 1efddcb into actions:main Jun 14, 2021
@C0ZEN C0ZEN deleted the feature/remove-stale-when-commented branch June 14, 2021 15:10
C0ZEN added a commit to C0ZEN/stale that referenced this pull request Jun 15, 2021
luketomlinson pushed a commit that referenced this pull request Jun 15, 2021
@C0ZEN C0ZEN restored the feature/remove-stale-when-commented branch June 15, 2021 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants