Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(exempt): add new options to exempt the milestones #279

Merged
merged 13 commits into from Jan 19, 2021

Conversation

C0ZEN
Copy link
Contributor

@C0ZEN C0ZEN commented Jan 18, 2021

Changes:

  • Add new options exempt-milestones, exempt-issue-milestones and exempt-pr-milestones
  • Undo the changes in the lint scripts to include Prettier
    • Did not saw that some scripts were already there to run Prettier
    • Instead create new scripts to run Prettier and ESLint (which is very useful for me at least)
  • Create an Issue class to contains all the related calculated data
    • Easier to use the calculated data
    • Make more sense in OOP world IMO
  • Create an Milestones class to handle all the logic regarding the milestones
  • Fix some small spellcheck issues
  • Renamed some models/functions
    • Some models were prefixed with I since it's an interface related to a class
    • The interface is clearly in that case an API model; can keep this convention if you are ok

Closes #270.
Partially closing #272.
Partially closing #236.

@C0ZEN
Copy link
Contributor Author

C0ZEN commented Jan 18, 2021

@hross if you have some time left, I would love to get some help to find the culprit regarding the failing check 😢

Edit:
I think it's related to some config options being optional but yet parsed as required numbers.
Need to update a bit the code here.

Edit 2:
The culprit was indeed optional number values and was not coming from this PR.
This was due to the fact that building the index was required in order to make the checks good and up-to-date.
IMO the index build should be inside the CI and should be ignored from the repo.

the code was actually handling the case where the values are NaN so it's fine
@hross hross merged commit f71123a into actions:main Jan 19, 2021
@C0ZEN C0ZEN deleted the feature/exempt-milestones branch January 19, 2021 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid stale for specific milestone(s) - Like label does
2 participants