From 7eca83fddfd3b49b7d99763dd195b27904e8ab83 Mon Sep 17 00:00:00 2001 From: 0x5c Date: Fri, 15 Apr 2022 16:15:53 -0400 Subject: [PATCH] Remove stale when updated without comment The existing logic for `remove-stale-when-updated` only considers presence of comments, ignoring the value of `issueHasUpdate`. This commits fixes it so it follows the documented behaviour for that setting. Fixes #715 --- src/classes/issues-processor.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/classes/issues-processor.ts b/src/classes/issues-processor.ts index 9cb1bb23f..1ddbadbd2 100644 --- a/src/classes/issues-processor.ts +++ b/src/classes/issues-processor.ts @@ -674,11 +674,11 @@ export class IssuesProcessor { // Should we un-stale this issue? if ( shouldRemoveStaleWhenUpdated && - issueHasComments && + (issueHasUpdate || issueHasComments) && !issue.markedStaleThisRun ) { issueLogger.info( - `Remove the stale label since the $$type has a comment and the workflow should remove the stale label when updated` + `Remove the stale label since the $$type has been updated and the workflow should remove the stale label when updated` ); await this._removeStaleLabel(issue, staleLabel);