Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support non-ubuntu linux distributions by specify location of versions-manifest.json #716

Open
ganadist opened this issue Aug 13, 2023 · 1 comment · May be fixed by #717
Open

Support non-ubuntu linux distributions by specify location of versions-manifest.json #716

ganadist opened this issue Aug 13, 2023 · 1 comment · May be fixed by #717
Labels
feature request New feature or request to improve the current logic investigation The issue is under investigation

Comments

@ganadist
Copy link

ganadist commented Aug 13, 2023 •
edited

Description:
I'm using GHES with runners under CentOS / Rocky Linux.
But setup-python is supported on recent Ubuntu versions only, and it fails on other linux distributions, yet.
So, I propose to support other linux distributions by simple changes.

Justification:

  • Recent actions/tool-cache library supports to determine platform version for non-ubuntu linux distros ( Get linux version from os-release file if available toolkit#594 )
  • setup-python actions has hard coded location of versions-manifest.json.
    If location of versions-manifest.json can be provided users, actions can be used for various linux platform.
    I propose 3 inputs options for this.
    • versions-manifest-repo-owner : Github owner of versions-manifest.json
    • versions-manifest-repo-name : Github repository of versions-manifest.json
    • versions-manifest-repo-branch : Github branch of versions-manifest.json
      If these values are not set, default value should be same with current behavior.

Are you willing to submit a PR?

I'll try it :D
@ganadist ganadist added feature request New feature or request to improve the current logic needs triage labels Aug 13, 2023
@ganadist ganadist linked a pull request Aug 13, 2023 that will close this issue
Open
2 tasks
@dmitry-shibanov
Copy link
Contributor

Hello @ganadist. Thank you for your report. We'll take a look at this feature request.

@dmitry-shibanov dmitry-shibanov added investigation The issue is under investigation and removed needs triage labels Aug 14, 2023
@create-issue-branch create-issue-branch bot mentioned this issue Jan 23, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature request New feature or request to improve the current logic investigation The issue is under investigation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add inputs options to change location of versions-manifest.json ganadist/setup-python
2 participants
@ganadist @dmitry-shibanov