Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying x86 (32-bit) pypy-nightly on Windows installs a 64-bit binary #518

Closed
2 of 5 tasks
alex opened this issue Oct 9, 2022 · 6 comments
Closed
2 of 5 tasks
Assignees
Labels
bug Something isn't working

Comments

@alex
Copy link

alex commented Oct 9, 2022

Description:

      - name: Setup python
        uses: actions/setup-python@v4.2.0
        with:
          python-version: "pypy-3.8-nightly"
          architecture: "x86"

Action version:

4.2.0

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:

pypy-3.8-nightly, pypy-3.9-nightly

Repro steps:

Use the action specified above. Look at the output and see:

Downloading PyPy from "https://buildbot.pypy.org/nightly/py3.8/pypy-c-jit-latest-win64.zip" ...

Expected behavior:

A 32-bit binary is installed.

Actual behavior:
A 64-bit binary!

@nulano
Copy link

nulano commented Oct 9, 2022

Expected behavior:
A 32-bit binary is installed.

There is no 32-bit Windows build of recent PyPy versions since PyPy 7.3.4.

Actual behavior:
A 64-bit binary!

Whether this action should fail or silently switch to 64-bit is a separate question, related to #168 (comment) and #201.

@alex
Copy link
Author

alex commented Oct 9, 2022

Hmm, indeed. I think this should be an error then, its very confusing to request one thing and get another -- in my case it produces confusing linker errors later on.

@vsafonkin
Copy link

Hi @alex, we will take a look at this, thank you for your report.

@vsafonkin
Copy link

vsafonkin commented Oct 18, 2022

Hi @alex, i've merged this PR to fix it. It's available via setup-python@main at the moment and will be available via version tag after a new release of setup-python action.

@alex
Copy link
Author

alex commented Oct 18, 2022

great, thanks!

@vsafonkin
Copy link

I'm going to close this issue, feel free to contact us if you have any concerns, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants