Add warning if python version set to empty value #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marko-zivic-93
approved these changes
Apr 29, 2022
marko-zivic-93
approved these changes
Apr 29, 2022
brcrista
reviewed
Apr 29, 2022
Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>
marko-zivic-93
approved these changes
May 4, 2022
vsafonkin
approved these changes
May 4, 2022
brcrista
approved these changes
May 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
There was a request to add non-zero exit in case if
python-versioninput set to zero value, but @dmitry-shibanov warned it might break the existing builds.I suggest to add a warning to the log instead of of non-zero exit code.
There's a build confirming no tool-cache python installed if python-version is empty.
Related issue:
related issue.
Check list: