Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in caching for poetry dependencies #298

Closed
floatingpurr opened this issue Dec 14, 2021 · 2 comments
Closed

Built-in caching for poetry dependencies #298

floatingpurr opened this issue Dec 14, 2021 · 2 comments
Labels
feature request New feature or request to improve the current logic

Comments

@floatingpurr
Copy link

floatingpurr commented Dec 14, 2021

Description:
As per the doc, here and here, setup-python supports built-in caching of pip and pipenv dependencies. It'd nice to have the same feature also for Poetry out-of-the-box.

Justification:
Poetry is one of the latest projects joining the party of Python dependency management systems. If you want to cache inter-run dependencies, you have to build your own caching step (e.g., this):

- name: Set up cache
      uses: actions/cache@v1
      with:
        path: .venv
        key: venv-${{ runner.os }}-${{ steps.full-python-version.outputs.version }}-${{ hashFiles('**/poetry.lock') }}

I'd great if that were managed by setup-python!

Are you willing to submit a PR?
Please, note that I'm not familiar with TS. Looking for support / hints.

@floatingpurr floatingpurr added feature request New feature or request to improve the current logic needs triage labels Dec 14, 2021
@nikita-bykov
Copy link
Contributor

Hello @floatingpurr, thanks for your feature request!
The related PR for adding poetry caching support already exists.
We'll review it as soon as possible.

@floatingpurr
Copy link
Author

Hi @nikita-bykov, thanx for the pointer. I hadn't found such a PR when I opened up this feature request. Sorry for that. I'm gonna close this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

2 participants