Add poetry caching support #281

patrick91 · 2021-11-24T14:52:54Z

Description:
A continuation of #266 to add support for caching poetry's virtualenv

This is still draft, I need to implement the actual caching, but it is good to start running the tests early :)

Check list:

Mark if documentation changes are required.
Mark if tests were added or updated to cover the changes.

__tests__/cache-restore.test.ts

src/cache-distributions/poetry-cache.ts

.github/workflows/e2e-cache.yml

patrick91 · 2021-11-27T17:20:22Z

I've tested this here: https://github.com/patrick91/test-action-poetry-cache/runs/4341929604?check_suite_focus=true

floatingpurr · 2021-12-22T15:29:47Z

Great improvement!

dimaqq · 2022-01-20T08:09:37Z

Keep going! :)

Zxilly · 2022-01-30T11:14:55Z

Any update on this?

patrick91 · 2022-01-31T14:51:32Z

Any update on this?

I've rebased the PR, but we have to wait the mainteners to review the PR. They are probably busy with other priorities so we'll probably have to wait a bit 😊

.github/workflows/e2e-cache.yml

__tests__/data/.tool-versions

src/cache-distributions/poetry-cache.ts

dmitry-shibanov · 2022-02-18T09:29:36Z

Could you please sync with the main branch ?

patrick91 · 2022-02-18T17:32:54Z

I closed this by mistake :) @dmitry-shibanov the PR should be up to date now!

dmitry-shibanov · 2022-02-21T12:55:06Z

Hello @patrick91. Could you please run these commands:

npm run build
npm run format

patrick91 · 2022-02-21T16:41:58Z

@dmitry-shibanov done!

patrick91 · 2022-02-25T00:09:24Z

Not 100% sure why the CI failied, I'll try to take a look soon, maybe a rebase helps 😊

patrick91 · 2022-03-07T02:30:59Z

Rebased this again :)

m0ar · 2022-03-09T09:19:45Z

Super stoked for this! Keep the good work up @patrick91 💘

rc-mattschwager · 2022-03-25T17:54:36Z

Friendly bump here, can a maintainer at least approve the CI workflows so the submitter can see if everything's still passing?

First-time contributors need a maintainer to approve running workflows.

patrick91 · 2022-03-29T19:30:18Z

@dmitry-shibanov pipenv seems to fail on main too, shall I sent a PR to try and fix that?

Also I did rebase and ran npm run build && npm run format, but the check is still failing 🤔

brcrista · 2022-03-30T15:04:39Z

@patrick91 I looked at that failure briefly but couldn't figure it out. If you know what the issue is and want to submit a separate PR, that would be great. Otherwise, we don't need to block this on that.

What you do need to fix is the check-dist failure. You can just download the artifact from that run and check it in.

patrick91 · 2022-03-30T15:30:26Z

@brcrista done 😊

src/cache-distributions/poetry-cache.ts

Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>

brcrista

Thank you @patrick91!

Zxilly · 2022-03-31T17:36:15Z

nice work

m0ar · 2022-04-01T07:51:03Z

@patrick91 Thank you! 🧁 💘

As of yesterday, `@actions/setup-python@v3` supports this via v3.1.0: [Release](https://github.com/actions/setup-python/releases/tag/v3.1.0), [Tag](https://github.com/actions/setup-python/tree/v3.1.0), actions/setup-python#281 ```yaml steps: - uses: actions/checkout@v3 - name: Install poetry run: pipx install poetry - uses: actions/setup-python@v3 with: python-version: '3.9' cache: 'poetry' - run: poetry install - run: poetry run pytest ``` See also: python-poetry/poetry#4205

…ython@v3 poetry install will pick up the python binary at the time it was installed (before actions/python ran) so it looks like poetry env needs to be set manually. https://github.com/actions/setup-python/releases/tag/v3.1.0 https://github.com/actions/setup-python/tree/v3.1.0 actions/setup-python#281

patrick91 force-pushed the feature/poetry-caching branch from 7dc18af to 63a127c Compare November 24, 2021 19:58

patrick91 commented Nov 24, 2021

View reviewed changes

__tests__/cache-restore.test.ts Show resolved Hide resolved

src/cache-distributions/poetry-cache.ts Outdated Show resolved Hide resolved

.github/workflows/e2e-cache.yml Outdated Show resolved Hide resolved

patrick91 force-pushed the feature/poetry-caching branch from f1b64ab to 63a127c Compare November 27, 2021 11:27

patrick91 marked this pull request as ready for review November 27, 2021 17:20

patrick91 force-pushed the feature/poetry-caching branch from da28c46 to 99a5f2b Compare November 27, 2021 17:20

nikita-bykov mentioned this pull request Dec 15, 2021

Built-in caching for poetry dependencies #298

Closed

browniebroke mentioned this pull request Jan 14, 2022

replace the old building and packaging tools with poetry cookiecutter/cookiecutter#1638

Closed

patrick91 force-pushed the feature/poetry-caching branch from 99a5f2b to 0f8afe0 Compare January 31, 2022 14:39

DMRobertson mentioned this pull request Feb 2, 2022

GitHub action to setup poetry matrix-org/setup-python-poetry#1

Merged

dmitry-shibanov reviewed Feb 18, 2022

View reviewed changes

.github/workflows/e2e-cache.yml Outdated Show resolved Hide resolved

__tests__/data/.tool-versions Outdated Show resolved Hide resolved

src/cache-distributions/poetry-cache.ts Outdated Show resolved Hide resolved

src/cache-distributions/poetry-cache.ts Outdated Show resolved Hide resolved

patrick91 closed this Feb 18, 2022

patrick91 force-pushed the feature/poetry-caching branch from 0f8afe0 to 7f80679 Compare February 18, 2022 17:25

patrick91 reopened this Feb 18, 2022

patrick91 force-pushed the feature/poetry-caching branch from 92cd993 to a1cc6a7 Compare February 21, 2022 17:02

patrick91 force-pushed the feature/poetry-caching branch 2 times, most recently from 57c8ee5 to a580a2d Compare February 26, 2022 04:19

patrick91 force-pushed the feature/poetry-caching branch from a580a2d to 86304bc Compare March 7, 2022 02:31

patrick91 added 9 commits March 25, 2022 22:53

Get poetry cache implementation when requested

95824fd

Add tests

1259541

Add more tests

7c950eb

Release

c275cf4

Parse values from poetry

42ed863

Reduce test matrix

415c356

Remove unused file

0ebf799

Remove console.log

b0c8e3d

Build and format

aac0ef9

patrick91 force-pushed the feature/poetry-caching branch from 86304bc to aac0ef9 Compare March 26, 2022 03:54

patrick91 requested a review from a team March 26, 2022 03:54

Initialise pyproject.toml

e4be7a4

Update dist

7a37d78

brcrista reviewed Mar 30, 2022

View reviewed changes

src/cache-distributions/poetry-cache.ts Outdated Show resolved Hide resolved

patrick91 and others added 2 commits March 30, 2022 22:41

Use \n instead of os.EOL

6c31eb3

Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>

Update dist

7aa3e95

brcrista approved these changes Mar 31, 2022

View reviewed changes

brcrista merged commit 6c56602 into actions:main Mar 31, 2022

patrick91 deleted the feature/poetry-caching branch March 31, 2022 21:44

tiwarishub mentioned this pull request Apr 1, 2022

dist fix #367

Merged

2 tasks

tony mentioned this pull request Apr 2, 2022

ci(tests): Use poetry cache action vcs-python/libvcs#316

Merged

tony mentioned this pull request Apr 3, 2022

v3.1's default poetry example uses wrong python version #374

Closed

5 tasks

jaagut mentioned this pull request May 17, 2022

Actions: Caching workflow dependencies: poetry package manager is missing github/docs#17926

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add poetry caching support #281

Add poetry caching support #281

patrick91 commented Nov 24, 2021 •

edited

patrick91 commented Nov 27, 2021

floatingpurr commented Dec 22, 2021

dimaqq commented Jan 20, 2022

Zxilly commented Jan 30, 2022

patrick91 commented Jan 31, 2022

dmitry-shibanov commented Feb 18, 2022

patrick91 commented Feb 18, 2022

dmitry-shibanov commented Feb 21, 2022

patrick91 commented Feb 21, 2022

patrick91 commented Feb 25, 2022

patrick91 commented Mar 7, 2022

m0ar commented Mar 9, 2022

rc-mattschwager commented Mar 25, 2022

patrick91 commented Mar 29, 2022

brcrista commented Mar 30, 2022

patrick91 commented Mar 30, 2022

brcrista left a comment

Zxilly commented Mar 31, 2022

m0ar commented Apr 1, 2022

Add poetry caching support #281

Add poetry caching support #281

Conversation

patrick91 commented Nov 24, 2021 • edited

patrick91 commented Nov 27, 2021

floatingpurr commented Dec 22, 2021

dimaqq commented Jan 20, 2022

Zxilly commented Jan 30, 2022

patrick91 commented Jan 31, 2022

dmitry-shibanov commented Feb 18, 2022

patrick91 commented Feb 18, 2022

dmitry-shibanov commented Feb 21, 2022

patrick91 commented Feb 21, 2022

patrick91 commented Feb 25, 2022

patrick91 commented Mar 7, 2022

m0ar commented Mar 9, 2022

rc-mattschwager commented Mar 25, 2022

patrick91 commented Mar 29, 2022

brcrista commented Mar 30, 2022

patrick91 commented Mar 30, 2022

brcrista left a comment

Choose a reason for hiding this comment

Zxilly commented Mar 31, 2022

m0ar commented Apr 1, 2022

patrick91 commented Nov 24, 2021 •

edited