Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved logging during setup #113

Merged
merged 3 commits into from
Jul 15, 2020
Merged

Conversation

konradpabjan
Copy link
Collaborator

Resolves: #103

Sample run where a job was intentionally failed: https://github.com/konradpabjan/Testing2/runs/874079531

Previously, the steps in red would just not show up:

image

Some of the lines such as Create Python 3.8.3 folder would also only show up with debug on.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@@ -6355,7 +6355,10 @@ function installPython(workingDirectory) {
silent: true,
listeners: {
stdout: (data) => {
core.debug(data.toString().trim());
core.info(data.toString().trim());
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@brcrista brcrista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple edits on the docs. Good improvement, thanks!

Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>
@konradpabjan konradpabjan merged commit 7a69c2b into main Jul 15, 2020
@konradpabjan konradpabjan deleted the konradpabjan/improved-error-output branch July 15, 2020 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve error messages when installing Python on a self-hosted runner
2 participants