Add support of pre-release Python versions #112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/find-python.ts
Outdated
| @@ -171,14 +173,15 @@ export function pythonVersionToSemantic(versionSpec: string) { | |||
|
|
|||
| export async function findPythonVersion( | |||
There was a problem hiding this comment.
@bryanmacfarlane , @konradpabjan , there is a function pythonVersionToSemantic that converts version from format 3.7.0b2 to 3.7.0-b2. Not sure why this function was needed before because we have never added pre-release versions previously (may be self-hosted?). May be it makes sense to modify this function to convert from 3.7.0b2 to 3.7.0-beta.2 so version will be resolved from manifest?
https://github.com/actions/setup-python/pull/112/files#diff-7159c6139aba803e6290bd5cb287d23fR169
MaksimZhukov
changed the title
maxim-lobanov
approved these changes
Jul 16, 2020
konradpabjan
approved these changes
Jul 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In scope of this PR we've added ability to set up pre-release Python versions.
Details:
There are several ways to specify pre-release versions, for example:
3.9.0-beta.4to set up an exact pre-release version3.9.0-alpha - 3.9.0to set up the latest available version of Python (including both pre-release and stable versions).Currently, we do not preinstall pre-release versions on our images. All available pre-release versions will be downloaded and installed in runtime from versions-manifest.json located in the actions/python-versions repository.
Also we've updated tests to cover set up of pre-release versions.