Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

incorrect installation of dependencies #105

Closed
2 of 7 tasks
j0nm1 opened this issue Jul 6, 2020 · 1 comment
Closed
2 of 7 tasks

incorrect installation of dependencies #105

j0nm1 opened this issue Jul 6, 2020 · 1 comment
Labels
bug Something isn't working

Comments

@j0nm1
Copy link

j0nm1 commented Jul 6, 2020

Describe the bug
When using a python-version that is not installed on the runner, the dependencies seem to get installed differently. This is a problem when using isort because it will scan all dependencies as well. When using 3.8.2 isort fails, with 3.8.3 it works fine.

Which version of the action are you using?

  • v1
  • v2
  • Some other tag (such as v2.0.1 or master)

Environment

  • self-hosted
  • Linux
  • Windows
  • Mac

Python Versions
Only tested with 3.8.2

To Reproduce

name: Standard Pipeline

on:
  pull_request:
    branches: '**'

jobs:
  isort:
    runs-on: ubuntu-latest
    steps:
    - uses: actions/checkout@v2
    - uses: actions/setup-python@v2
      with:
        python-version: 3.8.2

    - name: pip install
      run: pip install -r requirements.txt

    - name: isort
      run: isort --check .

Run/Repo Url
osbdr/pipeline-python-demo#16

Screenshots
With 3.8.2

image

With 3.8.3

image

@j0nm1 j0nm1 added the bug Something isn't working label Jul 6, 2020
@konradpabjan
Copy link
Collaborator

This should be resolved now. The root cause was #101 and #106

Version 3.8.3 was cached and pre-installed on our hosted runners while 3.8.2 had to be downloaded and installed. I tested with the v2 tag that was updated with the most recent fixes and isort passes. An older tag (v2.1.0) fails.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants