New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lts/*
installs old LTS version intermittently
#940
Comments
lts/*
lts/*
installs old LTS version
Looks like the manifest might be here (maybe this should be linked in the output of https://www.github.com/actions/node-versions/blob/main/versions-manifest.json I opened a PR there as well, in case that's a better place to discuss: |
Hello @karlhorky |
Hello @karlhorky |
@HarithaVattikuti I just tried re-running my job and it's still on Node.js
|
Is there any way I can manually clear the manifest cache on GitHub Actions? I know that you can clear other named caches, but these are unrelated to the manifest cache, from what I can tell. |
@HarithaVattikuti now it's working, thanks!
Maybe I tried it before the change was fully rolled out. Closing. |
Interesting, this is still intermittently failing on some of our repositories (with a
https://github.com/upleveled/hotline-bling-codealong/actions/runs/7667389682/job/20897108024?pr=164 @HarithaVattikuti maybe there's a problem with the caches? Reopening for visibility. |
lts/*
installs old LTS versionlts/*
installs old LTS version intermittently
Hello @karlhorky, |
Oh wow, that's a surprising detail 🤔 To me, it seems like Node.js If it would be possible to fix that and return the latest LTS, I'm sure that would be widely appreciated and reduce confusion. |
Update: this continues to be a problem with Node.js v20.12.0 - the - name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: 'lts/*'
cache: 'pnpm' Logs for the workflow run:
|
@HarithaVattikuti can you reopen this issue please? Or if not, I'll create a new issue. |
@aparnajyothi-y if you are taking this over, could you reopen this issue? |
Hello @karlhorky, I have tried to run the same job to use lts* in my local and it is downloading the latest version 20.12.0. If we want to keep the caching but ensure that always using the latest LTS version then add a step to your workflow that updates Node.js to the latest LTS version after setting it up
|
@aparnajyothi-y what I think should be supported (and what I believe would be the behavior that users would expect and want):
|
Hello @karlhorky, We have furthermore investigated and found that the action itself doesn't control the cache, it's managed by the runner environment. Automatic cache eviction may need changes on the runner's side as setup-node uses the caching facilities provided by the runner environment, you can refer here. Automatic cache eviction is a potential feature where old or unused cached dependencies would be automatically removed. This ensures that the cache does not keep growing indefinitely and consume all available storage. |
I'm not sure I'm understanding what you're saying, but maybe you're saying this bug should be also reported somewhere else? Where exactly can this be reported also for the runners so that the behavior is automatic cache evictions (or cache upgrades) on new LTS versions? I and others think that the current behavior is broken, so it should be fixed. I assume it may not be the runner's responsibility to know about new LTS versions of Node.js (that seems like responsibility of
So, if this mental model is correct, there may need to be a "cache eviction API" exposed by the runner, in order for |
Hello @karlhorky, As we have mentioned in the above comment, this feature might be shared between the actions/setup-node and the GitHub Actions runner. The actions/setup-node should ideally handle actions related to the release of new LTS versions, while cache management is typically handled by the runner. |
Ok great, are you a part of the GitHub Actions team? Can you reach out to someone internally on the runner side to convey the need for a Cache Eviction API to allow for the I see that the following people are maintainers / contributors on the public GitHub repos, but I have no visibility / connections beyond that: |
Description:
Using the following configuration installs Node.js 20.10.0, an old version. Node.js 20.11.0 has been out since 10 Jan 2024.
The output looks like this:
Action version:
actions/setup-node@v4
Platform:
Runner type:
Tools version:
Node.js lts/*
Repro steps:
Use the configuration above and observe the output above
Expected behavior:
Node.js latest LTS (20.11.0) is installed
Actual behavior:
Node.js older LTS (20.10.0) is installed
cc @MaksimZhukov @dmitry-shibanov @dusan-trickovic
The text was updated successfully, but these errors were encountered: