Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiple node-version-file (string[]) #938

Open
y-nk opened this issue Jan 10, 2024 · 3 comments
Open

Multiple node-version-file (string[]) #938

y-nk opened this issue Jan 10, 2024 · 3 comments
Labels
feature request New feature or request to improve the current logic

Comments

@y-nk
Copy link

y-nk commented Jan 10, 2024

Description:

The idea would be to propose having an array of string when it comes to node-version-file so that it would have fallbacks if the file was not found

Justification:
Like many i'm using this action in a monorepo, where sometimes services/packages are not on par. Some have a .node-version file, some a .nvmrc file, and some a package.json file. I wished we could provide the 3 so that the first found gets picked.

Are you willing to submit a PR?
Yes, I could work on it.

@y-nk y-nk added feature request New feature or request to improve the current logic needs triage labels Jan 10, 2024
@y-nk
Copy link
Author

y-nk commented Jan 10, 2024

I'm thinking there will be an issue with having an array/list as param with the toolkit (actions/toolkit#184).

@aparnajyothi-y
Copy link
Contributor

Hello @y-nk ,
Thank you for creating this issue, we will investigate it and come back to you as soon as we have some feedback.

@greyaxie
Copy link

hello

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants