Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lts/ named aliases not resolving to correct sequence of versions #536

Closed
2 of 5 tasks
amclin opened this issue Jul 8, 2022 · 1 comment
Closed
2 of 5 tasks

lts/ named aliases not resolving to correct sequence of versions #536

amclin opened this issue Jul 8, 2022 · 1 comment
Assignees
Labels
bug Something isn't working

Comments

@amclin
Copy link

amclin commented Jul 8, 2022

Description:
New named aliases introduced in #481 are not resolving correctly. Using named alias lts/* on hosted GitHub runners resolves to Node v16 instead of the current LTS v18. As a result, each of the named aliases lts/-n are offset incorrectly. (-1 resolves to v14 instead of v16, -2 to v12, etc..)

Action version:
v3.3

Platform:

  • Ubuntu
  • macOS
  • Windows

Runner type:

  • Hosted
  • Self-hosted

Tools version:

Repro steps:
Setup GitHub action using aliases for node versions:
https://github.com/amclin/aem-packager/blob/master/.github/workflows/run-tests.yml

jobs:
  build:

    runs-on: ubuntu-latest

    strategy:
      matrix:
        node-version: ['lts/*', 'lts/-1', 'lts/-2']
        # See supported Node.js release schedule at https://nodejs.org/en/about/releases/

    steps:
    - uses: actions/checkout@v3
    - name: Use Node.js ${{ matrix.node-version }}
      uses: actions/setup-node@v3
      with:
        node-version: ${{ matrix.node-version }}

Expected behavior:

  • lts/-2 resolves to Node v14
  • lts/-1 resolves to Node v16
  • lts/* resolves to Node v18

Actual behavior:

@amclin amclin added bug Something isn't working needs triage labels Jul 8, 2022
@amclin amclin changed the title NPM lts/ aliases not resolving to correct sequence of versions lts/ named aliases not resolving to correct sequence of versions Jul 8, 2022
@dmitry-shibanov dmitry-shibanov self-assigned this Jul 8, 2022
@dmitry-shibanov
Copy link
Contributor

Hello @amclin. Thank you for your report. The node 18 is not in active status and it does not have the codename for now. When it goes to the active state the alias name will be added to node-versions.

For now I'm going to close the issue because it is an expected behaviour.

deining pushed a commit to deining/setup-node that referenced this issue Nov 9, 2023
Bumps [prettier](https://github.com/prettier/prettier) from 3.0.1 to 3.0.2.
- [Release notes](https://github.com/prettier/prettier/releases)
- [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
- [Commits](prettier/prettier@3.0.1...3.0.2)

---
updated-dependencies:
- dependency-name: prettier
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants