Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action should pretend a "cache miss" on networking issues #518

Closed
foxylion opened this issue Jun 13, 2022 · 2 comments
Closed

Action should pretend a "cache miss" on networking issues #518

foxylion opened this issue Jun 13, 2022 · 2 comments
Assignees
Labels
feature request New feature or request to improve the current logic

Comments

@foxylion
Copy link

Description:
Underlying infrastructure issue for GitHub artifacts cause a lot of issues for workflows depending directly or indirectly on actions that use the caching infrastructure from actions/toolkit. See actions/cache#820 for details.

I would highly suggest that this action should be more resilient regarding service outages in the backing caching infrastructure.

The issues of today would most probably not be visible if the cache action would do "nothing" (like a cache miss) when the caching backend can't be reached or the server responds with an incorrect answer.

The @actions/cache action does show how a resilient implementation can look like: https://github.com/actions/cache/blob/main/src/restore.ts#L55

Currently there is now exception catching done in the @actions/setup-node action: https://github.com/actions/setup-node/blob/main/src/cache-restore.ts#L44

Justification:
It is unacceptable that problems with GitHub caching/artifact infrastructure will effectively make most workflows unusable.

@IvanZosimov
Copy link
Contributor

Hi, @foxylion 👋 ! Thank you for the feature request! We will definitely take a look at that problem.

@IvanZosimov
Copy link
Contributor

Hi, @foxylion 👋! This PR mitigates the problem. By now I'm going to close this issue. If you have any additions feel free to ping us 💌

deining pushed a commit to deining/setup-node that referenced this issue Nov 9, 2023
…ions#518)

Bumps [all-contributors-cli](https://github.com/all-contributors/all-contributors-cli) from 6.26.0 to 6.26.1.
- [Release notes](https://github.com/all-contributors/all-contributors-cli/releases)
- [Commits](all-contributors/cli@v6.26.0...v6.26.1)

---
updated-dependencies:
- dependency-name: all-contributors-cli
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

2 participants