extend documentation on scope parameter
#470
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also ends all descriptions with a full stop (`.`).
tyrann0us
added a commit
to inpsyde/reusable-workflows
that referenced
this pull request
Apr 19, 2022
See actions/setup-node#470 for details.
|
@dmitry-shibanov FYI |
deining
pushed a commit
to deining/setup-node
that referenced
this pull request
Nov 9, 2023
Bumps [prettier](https://github.com/prettier/prettier) from 2.8.1 to 2.8.2. - [Release notes](https://github.com/prettier/prettier/releases) - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md) - [Commits](prettier/prettier@2.8.1...2.8.2) --- updated-dependencies: - dependency-name: prettier dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
In
writeRegistryToFile()(added in https://github.com/actions/setup-node/pull/21/files#diff-a3c83546a6fde2740e1dd05c8267c74af1c8a7fe3add285eea3669b3760ac6f3R25-R27),scopefalls back to the repository owner if thenpm.pkg.github.comregistry (GitHub Packages) is used.Since in most cases, this means that the
scopeparameter is not needed, but the logic is not documented anywhere, this PR adds the appropriate note to the parameter description.Related issue:
None.
Check list: