Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated documentation/workflows to use actions/setup-node@v3 #433

Merged
merged 3 commits into from Mar 31, 2022
Merged

Updated documentation/workflows to use actions/setup-node@v3 #433

merged 3 commits into from Mar 31, 2022

Conversation

magnetikonline
Copy link
Contributor

@magnetikonline magnetikonline commented Mar 2, 2022

Description:

  • Congrats on the @v3 release - noted that some documentation hasn't been updated to suit.
  • Left the ADRs as is - figured they should be "frozen in time" of authoring.
  • Also updated internal GitHub workflows that use itself to @v3.
  • Also fixed the README.md build badges to the new format generated by the GitHub Actions UI (Create status badge).

Related issue:
N/A

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@magnetikonline magnetikonline changed the title Update readme workflow v3 Updated documentation/workflows to use actions/setup-node@v3 Mar 2, 2022
@magnetikonline
Copy link
Contributor Author

ping @brcrista

@vsafonkin vsafonkin mentioned this pull request Mar 31, 2022
2 tasks
Copy link
Contributor

@brcrista brcrista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @magnetikonline !

Comment on lines +3 to +5
[![build-test](https://github.com/actions/setup-node/actions/workflows/build-test.yml/badge.svg)](https://github.com/actions/setup-node/actions/workflows/build-test.yml)
[![versions](https://github.com/actions/setup-node/actions/workflows/versions.yml/badge.svg)](https://github.com/actions/setup-node/actions/workflows/versions.yml)
[![proxy](https://github.com/actions/setup-node/actions/workflows/proxy.yml/badge.svg)](https://github.com/actions/setup-node/actions/workflows/proxy.yml)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@brcrista brcrista merged commit 546fd45 into actions:main Mar 31, 2022
@magnetikonline
Copy link
Contributor Author

Thx @brcrista 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants