Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cache Size: ~0 MB (22 B) #281

Closed
michalsanger opened this issue Jul 2, 2021 · 5 comments
Closed

Cache Size: ~0 MB (22 B) #281

michalsanger opened this issue Jul 2, 2021 · 5 comments
Assignees

Comments

@michalsanger
Copy link

I'm trying the new cache: 'yarn' input, but for some unknown reason the cache is created empty:
https://github.com/adeira/universe/runs/2972556811?check_suite_focus=true#step:3:19

Any idea what could be the reason or how to fix it?
Thank you.

@dmitry-shibanov
Copy link
Contributor

Hello @michalsanger. Thank you for you report. I think the root cause of the issue that you use FORCE_COLOR. Output from yarn cache dir gets extra output for color, that is why action can't find proper path and packs empty directory. If you remove FORCE_COLOR, action will work as expected.

michalsanger added a commit to adeira/universe that referenced this issue Jul 5, 2021
@mrtnzlml
Copy link

mrtnzlml commented Jul 5, 2021

Output from yarn cache dir gets extra output for color, that is why action can't find proper path and packs empty directory.

Hi @dmitry-shibanov! Thanks for your suggestion. Would it be possible to improve the handling of such situations and throw an error when the path cannot be resolved? I think it would make more sense instead of trying to cache a directory that doesn't exist. 🤔

@dmitry-shibanov
Copy link
Contributor

Hello @mrtnzlml. Thank you for your response. I agree with you that it makes sense to add this check. We'll keep the issue open until we add this check.

michalsanger added a commit to adeira/universe that referenced this issue Jul 6, 2021
kodiakhq bot pushed a commit to adeira/universe that referenced this issue Jul 6, 2021
adeira-github-bot pushed a commit to adeira/sx-tailwind-website that referenced this issue Jul 6, 2021
Should work now:
actions/setup-node#281 (comment)

adeira-source-id: f9a1cd936e84c81ad73ff26519d473dc93d42d99
@XhmikosR
Copy link

XhmikosR commented Jul 8, 2021

We are using FORCE_COLOR: 2 and it seems to work fine. That being said, I agree this should be handled in a better way.

@dmitry-shibanov
Copy link
Contributor

Hello everyone. We've added check for existing directory in scope of this pull request. If directory for cache does not exist, post step will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants