Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap to env files #200

Merged
merged 4 commits into from
Oct 1, 2020
Merged

Swap to env files #200

merged 4 commits into from
Oct 1, 2020

Conversation

thboop
Copy link
Contributor

@thboop thboop commented Sep 29, 2020

The newest toolkit version uses Environment files to communicate with the Runner. This pr moves towards the new way of communicating with the runner and updates the toolkit version if appropriate.

@thboop thboop force-pushed the swapToEnvFiles branch 2 times, most recently from c910bc0 to 13d38a5 Compare September 29, 2020 16:39
@bryanmacfarlane
Copy link
Member

Probably good to bump the minimum here to ^1.2.6 https://github.com/actions/setup-node/blob/main/package.json#L26

@bryanmacfarlane
Copy link
Member

Outside of that, looks good.

Copy link
Member

@bryanmacfarlane bryanmacfarlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feel free to merge after the suggested change

@thboop thboop merged commit c6fd00c into main Oct 1, 2020
@thboop thboop deleted the swapToEnvFiles branch October 1, 2020 16:03
tcamde added a commit to tcamde/setup-node that referenced this pull request Oct 6, 2020
Krenair added a commit to alphagov/re-rotas that referenced this pull request Nov 17, 2020
…tup-node

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
contains:
`Action authors who are using the toolkit should update the @actions/core package to v1.2.6 or greater to get the updated addPath and exportVariable functions.`
and
`Action and workflow authors who are setting environment variables via STDOUT should update any usage of the set-env and add-path workflow commands to use the new environment files.`

Which setup-node appear to have done in actions/setup-node#200
The commits for which have been tagged v2.1.2.
Krenair added a commit to alphagov/re-rotas that referenced this pull request Nov 17, 2020
…tup actions

https://github.blog/changelog/2020-10-01-github-actions-deprecating-set-env-and-add-path-commands/
contains:
`Action authors who are using the toolkit should update the @actions/core package to v1.2.6 or greater to get the updated addPath and exportVariable functions.`
and
`Action and workflow authors who are setting environment variables via STDOUT should update any usage of the set-env and add-path workflow commands to use the new environment files.`

Which setup-node appear to have done in actions/setup-node#200 - the commits for which have been tagged v2.1.2.
And which setup-ruby appear to have done in ruby/setup-ruby#91 - the commits for which have been tagged v1.46.1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants