Fix support for Zulu arm64 architecture #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Azul API stopped to support arm64 architecture, the only supported option for ARM cpus is now 'arm'. This requires to set up hw_bitness properly to get 64 bits version. 32 bits version can be obtained by using 'arm' as an architecture.
e-korolevskii
approved these changes
Jun 9, 2022
dmitry-shibanov
approved these changes
Jun 9, 2022
marko-zivic-93
approved these changes
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
For Azul OpenJDK one of the supported architectures is arm64, eg.:
https://api.azul.com/zulu/download/community/v1.0/bundles/?os=linux&ext=tar.gz&bundle_type=jdk&javafx=false&arch=arm64&hw_bitness=&release_status=ga
However, value 'arm64' for architecture is not listed as available option in official API docs:
https://app.swaggerhub.com/apis-docs/azul/zulu-download-community/1.0#/bundles/get_bundles_
According to the docs, a combination of arch=arm and proper hw_bitness should be used. Also, today temporarily arm64 stopped working, giving
{"arch":["Select a valid choice. arm64 is not one of the available choices."]}error.I believe it's safer to use a supported combination of arch and hw_bitness. The same is currently done for x64 - it is translated to
arch=x86&hw_bitness=64even though x64 currently works when querying API:https://api.azul.com/zulu/download/community/v1.0/bundles/?os=linux&ext=tar.gz&bundle_type=jdk&javafx=false&arch=x64&hw_bitness=&release_status=ga
Related issue:
Check list: