Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Add config instructions on JavaFX Maven project #568

Open
LingkKang opened this issue Dec 10, 2023 · 1 comment
Open

Docs: Add config instructions on JavaFX Maven project #568

LingkKang opened this issue Dec 10, 2023 · 1 comment
Labels
feature request New feature or request to improve the current logic

Comments

@LingkKang
Copy link

Description

I have found that issue #18 and PR #27 enabled the action to work on JavaFX projects, but it seems that this part lacks some documentation.

This would be very helpful if README can have more explicit record on it.

Are you willing to submit a PR?

Unfortunately, I have not completely figure out how to make it work.

My understanding is, for a JavaFX project using Maven:

  1. Add javafx-maven-plugin in pom.xml according to Getting Started with JavaFX
  2. Config the ci file as follows:
distribution: 'zulu'
cache: maven
java-package: jdk+fx
  1. Use mvn compile or mvn javafx:run to compile/run the project in CI

If this is correct and nothing was missing, I'm glad to help.

Additionally, I'm not sure why using other distribusion of jdk cannot work, even maven can download JavaFX dependencies automatically.

@LingkKang LingkKang added feature request New feature or request to improve the current logic needs triage labels Dec 10, 2023
@IvanZosimov
Copy link
Contributor

Hi, @LingkKang 👋 Thanks for the issue, we will take a look and get back to you with updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

2 participants