Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default architecture to runner's architecture #375

Closed
cap10morgan opened this issue Aug 29, 2022 · 7 comments
Closed

Default architecture to runner's architecture #375

cap10morgan opened this issue Aug 29, 2022 · 7 comments
Assignees
Labels
feature request New feature or request to improve the current logic

Comments

@cap10morgan
Copy link
Contributor

Description:
If the architecture param isn't set, it currently defaults to amd64/x64/x86-64/etc. It should instead default to the runner's architecture.

Justification:
Hopefully self-evident

Are you willing to submit a PR?
Yes, I have a proof-of-concept one ready to go for further discussion.

@cap10morgan cap10morgan added feature request New feature or request to improve the current logic needs triage labels Aug 29, 2022
@panticmilos
Copy link
Contributor

Hi @cap10morgan, thank you for submitting the report and creating PR for it. We will take a look :)

@panticmilos panticmilos self-assigned this Aug 29, 2022
@tuckstarrydell
Copy link

#370 #268 #368 #373 #377

@Fleshgrinder
Copy link

I got tired and created a wrapping action: https://github.com/Fleshgrinder/setup-java

@cap10morgan
Copy link
Contributor Author

PR #376 is hopefully being merged soon so this will be implemented here shortly.

@dmitry-shibanov
Copy link
Contributor

Hello @cap10morgan. We released a new version of the action with these changes and updated the major tag. Could you please confirm that everything works as expected.

@cap10morgan
Copy link
Contributor Author

Hello @cap10morgan. We released a new version of the action with these changes and updated the major tag. Could you please confirm that everything works as expected.

Looks good here!

@dmitry-shibanov
Copy link
Contributor

In this case I'm going to close the issue. If you have any concerns feel free to ping us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

5 participants