Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action should pretend a "cache miss" on networking issues #344

Closed
foxylion opened this issue Jun 13, 2022 · 2 comments
Closed

Action should pretend a "cache miss" on networking issues #344

foxylion opened this issue Jun 13, 2022 · 2 comments
Assignees
Labels
feature request New feature or request to improve the current logic

Comments

@foxylion
Copy link

Description:
Underlying infrastructure issue for GitHub artifacts cause a lot of issues for workflows depending directly or indirectly on actions that use the caching infrastructure from actions/toolkit. See actions/cache#820 for details.

I would highly suggest that this action should be more resilient regarding service outages in the backing caching infrastructure.

The issues of today would most probably not be visible if the cache action would do "nothing" (like a cache miss) when the caching backend can't be reached or the server responds with an incorrect answer.

The @actions/cache action does show how a resilient implementation can look like: https://github.com/actions/cache/blob/main/src/restore.ts#L55

Currently there is now exception catching done in the @actions/setup-java action: https://github.com/actions/setup-java/blob/main/src/cache.ts#L90

Justification:
It is unacceptable that problems with GitHub caching/artifact infrastructure will effectively make most workflows unusable.

@e-korolevskii
Copy link
Contributor

Hello @foxylion

Thank you for your report. We'll investigate this feature request.

@brcrista
Copy link
Contributor

Resolved by #347

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants