Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide JDK 18 #304

Closed
apupier opened this issue Mar 25, 2022 · 9 comments
Closed

Provide JDK 18 #304

apupier opened this issue Mar 25, 2022 · 9 comments
Assignees
Labels
feature request New feature or request to improve the current logic

Comments

@apupier
Copy link

apupier commented Mar 25, 2022

Description:

For Oracle OpenJDK 18 has been released. https://openjdk.java.net/projects/jdk/18/

For AdoptOpenJDK, I think it is related to the Temurin and so to this ticket adoptium/adoptium#130

For Zulu, seems it is released https://docs.azul.com/core/zulu-openjdk/release-notes/18-ga

For Liberica, seems available https://bell-sw.com/pages/downloads/#/java-18-current

For Microsoft, build not available currently on https://docs.microsoft.com/en-us/java/openjdk/download but might never be available as itis nto a LTS. based on https://docs.microsoft.com/en-us/java/openjdk/faq

We plan to release OpenJDK binaries for versions where there is mutual LTS consensus across OpenJDK contributors and vendors.

Justification:

JDK 18 is the latest release of Java.

Are you willing to submit a PR?
maybe for AdoptOpenJDK/Temurin when available if it is a low effort

@dmitry-shibanov
Copy link
Contributor

Hello @apupier. Thank you for your proposal. The action uses API to grab the latest versions of distributions. I can confirm that the Java 18 for Ubuntu can be installed for Liberica, Zulu and Temurin. Unfortunately, for Microsoft the action does not have an API to grab all available versions.

@JohannesLichtenberger
Copy link

Would be awesome, my builds currently fail, as I switched a project already to Java 18.

@dmitry-shibanov
Copy link
Contributor

Hello @JohannesLichtenberger. What distribution and os are you using?

@JohannesLichtenberger
Copy link

Ubuntu / Temurin, but actually I don't care which distribution :)

The workflow is this:
https://github.com/sirixdb/sirix/blob/master/.github/workflows/gradle.yml

@dmitry-shibanov
Copy link
Contributor

I think it's not an issue with setup-java itself, because the version setup step worked correctly.

@RealYusufIsmail
Copy link

RealYusufIsmail commented Apr 12, 2022

I am having an issue were it is recognising java adopt 18.

Could not find satisfied version for SemVer '18'.

This is what I have

 - name: Set up JDK 18
        uses: actions/setup-java@v3.1.1
        with:
          java-version: '18'
          distribution: 'adopt'

@jachro
Copy link

jachro commented Apr 12, 2022

I am having an issue were it is recognising java adopt 18.

Could not find satisfied version for SemVer '18'.

This is what I have

 - name: Set up JDK 18
        uses: actions/setup-java@v3.1.1
        with:
          java-version: '18'
          distribution: 'adopt'

I had the same problem and switching over to temurin did the trick:

        uses: actions/setup-java@v3
        with:
          distribution: 'temurin'
          java-version: '18'

@RealYusufIsmail
Copy link

I am having an issue were it is recognising java adopt 18.
Could not find satisfied version for SemVer '18'.
This is what I have

 - name: Set up JDK 18
        uses: actions/setup-java@v3.1.1
        with:
          java-version: '18'
          distribution: 'adopt'

I had the same problem and switching over to temurin did the trick:

        uses: actions/setup-java@v3
        with:
          distribution: 'temurin'
          java-version: '18'

Thank you very much.

@dmitry-shibanov
Copy link
Contributor

Hello everyone. Java 18 is available for AdoptOpenJDK (Temurin), Zulu and Liberica. The setup-java action does not provide Oracle. We have a separate issue with add it #69. For Microsoft builds are not available for now.

For now I'm going to close the issue. If you have any concerns feel free to ping us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

6 participants