Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup: Use --delete-secret-and-public-key to delete GPG_PRIVATE_KEY #226

Merged
merged 1 commit into from Sep 22, 2021

Conversation

bjhargrave
Copy link
Contributor

Description:
This deletes the secret key(s) and public keys(s) for the fingerprint
of the installed GPG_PRIVATE_KEY.

If the installed GPG_PRIVATE_KEY only contains a signing subkey without
the primary private key, the --delete-secret-and-public-key will
successfully delete the keys.

Related issue:
Issue #200 can occur when the installed GPG_PRIVATE_KEY only contains a signing subkey without
the primary private key.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@dmitry-shibanov
Copy link
Contributor

Hello @bjhargrave. Thank you for your pull request. We need some time to investigate the attached issue deeper.

@dmitry-shibanov
Copy link
Contributor

Hello @bjhargrave. Could you please run the npm run build command with npm 6.x to regenerate dist.

This deletes the secret key(s) and public keys(s) for the fingerprint
of the installed GPG_PRIVATE_KEY.

If the installed GPG_PRIVATE_KEY only contains a signing subkey without
the primary private key, the --delete-secret-and-public-key will
successfully delete the keys.

Signed-off-by: BJ Hargrave <bj@hargrave.dev>
@bjhargrave
Copy link
Contributor Author

Could you please run the npm run build command with npm 6.x to regenerate dist.

@dmitry-shibanov Done!

bjhargrave added a commit to bjhargrave/transformer that referenced this pull request Sep 21, 2021
This is temporary while we wait for GitHub to merge
actions/setup-java#226

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
@dmitry-shibanov dmitry-shibanov merged commit d34438b into actions:main Sep 22, 2021
bjhargrave added a commit to bjhargrave/transformer that referenced this pull request Sep 29, 2021
v2 has been updated to include
actions/setup-java#226 in the
https://github.com/actions/setup-java/commits/v2.3.1 release.

Signed-off-by: BJ Hargrave <hargrave@us.ibm.com>
ind1go added a commit to ind1go/cics-bundle-maven that referenced this pull request Apr 1, 2022
Signed-off-by: Ben Cox <1038350+ind1go@users.noreply.github.com>
davenice added a commit to IBM/cics-bundle-maven that referenced this pull request Apr 4, 2022
Revert to mainline GitHub action because actions/setup-java#226 merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants