Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create check-dist.yml #212

Merged
merged 3 commits into from Sep 13, 2021
Merged

Create check-dist.yml #212

merged 3 commits into from Sep 13, 2021

Conversation

brcrista
Copy link
Contributor

This adds a workflow to check the contents of the checked-in dist/index.js against the expected version.

See actions/upload-artifact#227 for background and rationale.

@konradpabjan
Copy link
Collaborator

No need for this, see #206

@brcrista
Copy link
Contributor Author

@konradpabjan @maxim-lobanov @KengoTODA I think there's value in using the same mechanism for all 1st-party actions. For cache we moved its existing step in the build job to its own check: actions/cache#618

Though I think the value is just in consistency, I don't think same job vs. different job is a huge deal.

@konradpabjan
Copy link
Collaborator

I think there's value in using the same mechanism for all 1st-party actions

I agree, it would be great for consistency to share the same mechanism. I don't quite remember when the previous check was added but it doesn't make sense for there to be multiple ones.

My vote goes towards getting rid of the existing one and using what's in the PR

@dmitry-shibanov
Copy link
Contributor

Hello @brcrista. Thank you for your pull request. Could you please remove this step and the verify-no-unstaged-changes.sh file.

@dmitry-shibanov dmitry-shibanov merged commit b02a107 into actions:main Sep 13, 2021
@brcrista brcrista deleted the brcrista/check-dist branch September 13, 2021 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants