Add 'go-version' Output #85

mcdonnnj · 2020-11-18T20:13:04Z

This provides a go-version output from this Action to provide the version that was installed. This is useful if you specify only a partial version such as 1.15, but need the full version installed such as 1.15.5 for later use in a workflow. This is similar to the same functionality in actions/setup-python -
https://github.com/actions/setup-python/blob/41b7212b1668f5de9d65e9c82aa777e6bbedb3a8/action.yml#L14-L16

Example

build.yml:

jobs:
  test:
    runs-on: ubuntu-latest
    steps:
      - id: setup-go
        uses: action/setup-go@v2.1.4
        with:
          go-version: '1.15'
      - name: Lookup go cache directory
        run: echo "GOCACHE_DIR=$(go env GOCACHE)" >> $GITHUB_ENV
      - uses: actions/cache@v2
        with:
          path: |
            ${{ env.GOCACHE_DIR }}
          key: "test-${{ runner.os }}-go${{ steps.setup-go.outputs.go-version }}"

mcdonnnj · 2021-02-07T20:15:24Z

Just a friendly bump/ping.

mvdan · 2022-04-07T01:22:33Z

Friendly bump @brcrista @magnetikonline :)

magnetikonline · 2022-04-07T01:54:05Z

action.yml

@@ -10,6 +10,9 @@ inputs:
  token:
    description: Used to pull node distributions from go-versions.  Since there's a default, this is typically not supplied by the user.
    default: ${{ github.token }}
+outputs:
+  go-version:
+    description: 'The installed Go version. Useful when given a version range as input.'
 runs:
  using: 'node12'


@mcdonnnj you should do a git rebase main - some of this is out of date.

Sorry, with no attention on this pull request it fell off my radar.

It happens to the best of us @mcdonnnj - just figured it might shake out any merge issues for you. 👍

magnetikonline · 2022-04-07T02:00:05Z

src/main.ts

+    // based on go/src/cmd/go/internal/version/version.go:
+    // fmt.Printf("go version %s %s/%s\n", runtime.Version(), runtime.GOOS, runtime.GOARCH)
+    // expecting go<version> for runtime.Version()
+    let goVersionOutput = [...goVersion.split(' ')[2]].slice(2).join('');


@mcdonnnj is this reliable cross-platform? Probably?

Also this is a simpler way?

Suggested change

let goVersionOutput = [...goVersion.split(' ')[2]].slice(2).join('');

let goVersionOutput = goVersion.split(' ')[2].slice(2);

Could probably avoid the use of goVersionOutput entirely too?

@magnetikonline Sorry I had to knock the cobwebs out because it's been a long while since I looked at this pull request. I'm not sure why I felt I needed to expand it to an array and join() but yes your suggestion works fine. I'd also be happy to remove the variable entirely if that is preferred.

I just double-checked that this worked cross-platform in this Action run with jobs using ubuntu-latest, macos-latest, and windows-latest.

Lovely 👍

+1 to @magnetikonline's suggestion, but we can also remove the magic number '2':

Suggested change

let goVersionOutput = [...goVersion.split(' ')[2]].slice(2).join('');

let goVersionOutput = goVersion.split(' ')[2].slice('go'.length);

It would also be great if you could factor out this version-parsing logic to its own function and add a quick test for it. I think this is enough:

const goVersionOutput = "go version go1.16.6 darwin/amd64"; expect(parseGoVersion(goVersionOutput)).toBe("1.16.6")

@magnetikonline @brcrista Please see aa36c7f for your consideration. Please let me know if you'd like me to make any changes.

Sorry was out for the weekend. @brcrista nice solution to the magic number 2 👍

magnetikonline · 2022-04-07T02:01:31Z

@mvdan I left some comments - but I don't have merge rights (I'm not a GitHub staffer!).

Over to @brcrista 👍 😄

This provides the semver version of Go that has been installed. This is useful if only a major or minor version has been provided as the input go-version value.

brcrista · 2022-04-08T13:37:36Z

@mcdonnnj looks like CI is failing. Could you run npm run format-check and fix any issues?

https://github.com/actions/setup-go/runs/5885728533?check_suite_focus=true#step:5:10

Simplify how the version is extracted and add a simple test at the same time. Co-authored-by: Peter Mescalchin <peter@magnetikonline.com> Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>

mcdonnnj · 2022-04-08T15:33:16Z

@mcdonnnj looks like CI is failing. Could you run npm run format-check and fix any issues?

https://github.com/actions/setup-go/runs/5885728533?check_suite_focus=true#step:5:10

@brcrista I've force-pushed with the corrected file.

brcrista

Thanks!

magnetikonline · 2022-04-10T22:28:54Z

Good result all round, worthy addition 👍

* Add go-version to action outputs This provides the semver version of Go that has been installed. This is useful if only a major or minor version has been provided as the input go-version value. * Convert version extraction to a function Simplify how the version is extracted and add a simple test at the same time. Co-authored-by: Peter Mescalchin <peter@magnetikonline.com> Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com> Co-authored-by: Peter Mescalchin <peter@magnetikonline.com> Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>

mvdan mentioned this pull request Apr 7, 2022

ci: investigate how to support wildcard Go versions like 1.18.x govim/govim#1153

Open

magnetikonline reviewed Apr 7, 2022

View reviewed changes

Add go-version to action outputs

2930331

This provides the semver version of Go that has been installed. This is useful if only a major or minor version has been provided as the input go-version value.

mcdonnnj force-pushed the improvement/add_go-version_output branch from 6adf460 to 2930331 Compare April 7, 2022 03:37

mcdonnnj requested a review from a team April 7, 2022 03:37

Convert version extraction to a function

b2f8b6e

Simplify how the version is extracted and add a simple test at the same time. Co-authored-by: Peter Mescalchin <peter@magnetikonline.com> Co-authored-by: Brian Cristante <33549821+brcrista@users.noreply.github.com>

mcdonnnj force-pushed the improvement/add_go-version_output branch from aa36c7f to b2f8b6e Compare April 8, 2022 15:31

brcrista approved these changes Apr 8, 2022

View reviewed changes

brcrista merged commit 4a4352b into actions:main Apr 8, 2022

mcdonnnj deleted the improvement/add_go-version_output branch April 8, 2022 16:24

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 'go-version' Output #85

Add 'go-version' Output #85

mcdonnnj commented Nov 18, 2020

mcdonnnj commented Feb 7, 2021

mvdan commented Apr 7, 2022

magnetikonline Apr 7, 2022

mcdonnnj Apr 7, 2022

magnetikonline Apr 7, 2022

magnetikonline Apr 7, 2022

magnetikonline Apr 7, 2022

mcdonnnj Apr 7, 2022

magnetikonline Apr 7, 2022

brcrista Apr 7, 2022

brcrista Apr 7, 2022

mcdonnnj Apr 8, 2022

magnetikonline Apr 10, 2022

magnetikonline commented Apr 7, 2022

brcrista commented Apr 8, 2022

mcdonnnj commented Apr 8, 2022

brcrista left a comment

magnetikonline commented Apr 10, 2022

	let goVersionOutput = [...goVersion.split(' ')[2]].slice(2).join('');
	let goVersionOutput = goVersion.split(' ')[2].slice(2);

Add 'go-version' Output #85

Add 'go-version' Output #85

Conversation

mcdonnnj commented Nov 18, 2020

Example

mcdonnnj commented Feb 7, 2021

mvdan commented Apr 7, 2022

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

magnetikonline commented Apr 7, 2022

brcrista commented Apr 8, 2022

mcdonnnj commented Apr 8, 2022

brcrista left a comment

Choose a reason for hiding this comment

magnetikonline commented Apr 10, 2022