New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for arm32 go arch #253
Add support for arm32 go arch #253
Conversation
@@ -17,6 +17,8 @@ inputs: | |||
default: false | |||
cache-dependency-path: | |||
description: 'Used to specify the path to a dependency file - go.sum' | |||
architecture: | |||
description: 'Target architecture for Go to use. Examples: x86, x64. Will use system architecture by default.' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe add another row called "default" and say something like "System architecture will be used as default value"
docs/adrs/0001-architecture.md
Outdated
@@ -0,0 +1,16 @@ | |||
## Architecture | |||
|
|||
You can use any of the [supported operating systems](https://docs.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners), and the compatible `architecture` can be selected using `architecture`. Values are `x86`, `x64`, `arm`, `arm64`, `amd64` (not all of the architectures are available on all platforms). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"...and the compatible architecture
can be selected using architecture
"
I would switch this with something like:
". Compatible architecture can be selected by specifying a value for 'architecture' input variable."
I think we should add e2e test with |
@vsafonkin I think we can't go with e2e tests because of the fact that this is for self hosted arm agents... |
Description:
This PR provides the functionality of specifying architecture for
actions/setup-go
. With this PR support for arm32 will be added as well.Check list: