Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for arm32 go arch #253

Merged
merged 14 commits into from Aug 12, 2022

Conversation

panticmilos
Copy link
Contributor

Description:
This PR provides the functionality of specifying architecture for actions/setup-go. With this PR support for arm32 will be added as well.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

@panticmilos panticmilos marked this pull request as ready for review August 9, 2022 06:21
@panticmilos panticmilos requested a review from a team August 9, 2022 06:21
@@ -17,6 +17,8 @@ inputs:
default: false
cache-dependency-path:
description: 'Used to specify the path to a dependency file - go.sum'
architecture:
description: 'Target architecture for Go to use. Examples: x86, x64. Will use system architecture by default.'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add another row called "default" and say something like "System architecture will be used as default value"

@@ -0,0 +1,16 @@
## Architecture

You can use any of the [supported operating systems](https://docs.github.com/en/actions/reference/virtual-environments-for-github-hosted-runners), and the compatible `architecture` can be selected using `architecture`. Values are `x86`, `x64`, `arm`, `arm64`, `amd64` (not all of the architectures are available on all platforms).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"...and the compatible architecture can be selected using architecture"
I would switch this with something like:
". Compatible architecture can be selected by specifying a value for 'architecture' input variable."

@vsafonkin
Copy link

I think we should add e2e test with architecture input.

@marko-zivic-93
Copy link
Contributor

@vsafonkin I think we can't go with e2e tests because of the fact that this is for self hosted arm agents...

@dmitry-shibanov dmitry-shibanov merged commit 268d8c0 into actions:main Aug 12, 2022
n33pm pushed a commit to n33pm/setup-go that referenced this pull request Oct 17, 2022
adilhusain-s pushed a commit to adilhusain-s/setup-go that referenced this pull request Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants