Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error handling for cache #238

Merged

Conversation

vsafonkin
Copy link

Added logic to handle cache errors similarly actions/cache:
https://github.com/actions/cache/blob/main/src/restore.ts#L33

Execution of the action is not interrupted if the cache restore operation returns an error.

@vsafonkin vsafonkin requested a review from a team June 14, 2022 09:11
Copy link
Contributor

@brcrista brcrista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go in the restoreCache() function from the @actions/cache toolkit package. That way everything that uses caching will handle 503s correctly.

@vsafonkin vsafonkin changed the title Error handling for cache restore Error handling for cache Jun 28, 2022
@brcrista
Copy link
Contributor

Upstream fix: actions/toolkit#1122

@vsafonkin vsafonkin requested a review from brcrista June 30, 2022 12:11
@vsafonkin
Copy link
Author

@brcrista, please review

Copy link
Contributor

@brcrista brcrista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We just have to bump @actions/cache to v3: actions/toolkit#1122

Sorry, missed the new changes

src/cache-save.ts Outdated Show resolved Hide resolved
Vladimir Safonkin added 2 commits July 1, 2022 09:25
@marko-zivic-93 marko-zivic-93 merged commit 84cbf80 into actions:main Jul 1, 2022
@vsafonkin vsafonkin deleted the v-vsafonkin/cache-error-handling branch July 1, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants