From 24dcf77679e7e013d5c3266bf66fb07ac43004cb Mon Sep 17 00:00:00 2001 From: Manuel Mendez Date: Tue, 14 Dec 2021 13:24:18 -0500 Subject: [PATCH] Do not export GOROOT This has not been necessary since [Go 1.9](https://go.dev/doc/go1.9#goroot) at least (although clunky to do so then) but definitely not since [Go 1.10](https://go.dev/doc/go1.10#goroot). This is cargo culting code that is more than 2 years out of date and runs into issues when multiple go versions are used in an action run. Signed-off-by: Manuel Mendez --- __tests__/setup-go.test.ts | 2 +- dist/index.js | 1 - src/main.ts | 1 - 3 files changed, 1 insertion(+), 3 deletions(-) diff --git a/__tests__/setup-go.test.ts b/__tests__/setup-go.test.ts index 6be0c03c8..c19a1a10a 100644 --- a/__tests__/setup-go.test.ts +++ b/__tests__/setup-go.test.ts @@ -244,7 +244,7 @@ describe('setup-go', () => { }); await main.run(); - expect(vars).toBe({GOROOT: 'foo'}); + expect(vars).toBe({}); }); it('finds a version of go already in the cache', async () => { diff --git a/dist/index.js b/dist/index.js index ac3d0e5c1..87ff0a4c8 100644 --- a/dist/index.js +++ b/dist/index.js @@ -2080,7 +2080,6 @@ function run() { let auth = !token || isGhes() ? undefined : `token ${token}`; const checkLatest = core.getBooleanInput('check-latest'); const installDir = yield installer.getGo(versionSpec, checkLatest, auth); - core.exportVariable('GOROOT', installDir); core.addPath(path_1.default.join(installDir, 'bin')); core.info('Added go to the path'); let added = yield addBinToPath(); diff --git a/src/main.ts b/src/main.ts index f785b85da..7a9c1f51d 100644 --- a/src/main.ts +++ b/src/main.ts @@ -23,7 +23,6 @@ export async function run() { const checkLatest = core.getBooleanInput('check-latest'); const installDir = await installer.getGo(versionSpec, checkLatest, auth); - core.exportVariable('GOROOT', installDir); core.addPath(path.join(installDir, 'bin')); core.info('Added go to the path');