Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Windows-arm #320

Merged
merged 6 commits into from Sep 26, 2022
Merged

Add support for Windows-arm #320

merged 6 commits into from Sep 26, 2022

Conversation

thboop
Copy link
Contributor

@thboop thboop commented Sep 16, 2022

Description:
This PR fixes an issue where older versions of powershell (powershell versus pwsh (powershell core) is used on windows. Due to that, the install-dotnet script fails to detect it is on a windows arm device, and installs the x64 version of dotnet.

So now we try to use powershell core if it exists, then fallback to powershell. This should not impact linux/mac os in any way.

Related issue:
Add link to the related issue.

Check list:

  • Mark if documentation changes are required.
  • Mark if tests were added or updated to cover the changes.

src/installer.ts Outdated Show resolved Hide resolved
thboop and others added 3 commits September 22, 2022 09:45
Co-authored-by: Ivan <98037481+IvanZosimov@users.noreply.github.com>
Copy link
Contributor

@e-korolevskii e-korolevskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vsafonkin vsafonkin merged commit a351d9e into actions:main Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants