Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for AWS CodeArtifact NuGet Repositories #371

Open
Habikki opened this issue Jan 20, 2023 · 1 comment
Open

Support for AWS CodeArtifact NuGet Repositories #371

Habikki opened this issue Jan 20, 2023 · 1 comment
Labels
feature request New feature or request to improve the current logic investigation The issue is under investigation

Comments

@Habikki
Copy link

Habikki commented Jan 20, 2023

Description:
My organization heavily uses AWS CodeArtifact for Private NuGet Package Hosting.

Currently we have a private action running the following lines on ubuntu-latest without much complaint:

- name: Prepare NuGet Repository
    run: | 
      dotnet tool install -g AWS.CodeArtifact.NuGet.CredentialProvider
      dotnet codeartifact-creds install
      dotnet nuget remove source nuget.org 
      dotnet nuget add source "${{ inputs.aws-code-artifact-nuget-source }}" -n "${{ inputs.nuget-feed-name }}"    
    shell: bash

Note: removal of the default nuget.org source is only necessary for us as our CodeArtifact Repository is configured as a pass through cache to nuget.org.

Justification:
Adding this into the upstream setup-dotnet action would allow us to deprecate our private action. I'm opening this as a feature request to gauge interest for others that desire this support.

Are you willing to submit a PR?
Absolutely! If additional interest, I'll pick this up in short order. If not, I'll manage a PR the next time I have to update my private action.

@Habikki Habikki added feature request New feature or request to improve the current logic needs triage labels Jan 20, 2023
@marko-zivic-93
Copy link
Contributor

Hello @Habikki
Thank you for your feature request, we will investigate it and come back to you as soon as we have some information 🙂

@nikolai-laevskii nikolai-laevskii added investigation The issue is under investigation and removed needs eyes labels Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic investigation The issue is under investigation
Projects
None yet
Development

No branches or pull requests

6 participants
@Habikki @IvanZosimov @marko-zivic-93 @panticmilos @nikolai-laevskii and others