Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a way to disable .NET Core 2.1 warning #251

Closed
kunga opened this issue Nov 24, 2021 · 5 comments
Closed

Add a way to disable .NET Core 2.1 warning #251

kunga opened this issue Nov 24, 2021 · 5 comments
Assignees
Labels
feature request New feature or request to improve the current logic

Comments

@kunga
Copy link

kunga commented Nov 24, 2021

Our builds are full of warnings:

.NET Core 2.1 is no longer supported and will not receive security updates in the future. Please refer to https://aka.ms/dotnet-core-support for more information about the .NET support policy.

We are sure, that our libraries are should be compiled and run under netstandard2.0.

<NoWarn>NETSDK1138</NoWarn> disables this warning during the build, but how to disable it during setup-dotnet?

@kunga kunga added feature request New feature or request to improve the current logic needs triage labels Nov 24, 2021
@codebude
Copy link

codebude commented Dec 8, 2021

I just wanted to say, that I would be happy too, if you could add a switch/flag/parameter that allows disabling of EOL warnings.

@zcsizmadia
Copy link

zcsizmadia commented Dec 8, 2021

https://andrewlock.net/fixing-build-warning-netsdk1138-when-building-end-of-life-projects-with-dotnet-5/ has some options, you can use to disable the build warnings.

The setup-dotnet step itself should not be too many warnings. I assume only one.

@kunga
Copy link
Author

kunga commented Dec 8, 2021

The setup-dotnet step itself should not be too many warnings. I assume only one.

One per each job (so up to 10-20 per workflow) :)

@mattjohnsonpint
Copy link

Workaround: If you supply the exact version, the warning does not appear.

Instead of dotnet-version: 2.1.x, use dotnet-version: 2.1.818

@IvanZosimov
Copy link
Contributor

IvanZosimov commented Sep 30, 2022

Hi, the issue was solved in the new v3 version of setup-dotnet action.
By now I'm going to close this issue, If you have any additions or questions feel free to ping us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

6 participants