Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write resolved sdk version to output variable #241

Closed
MeikTranel opened this issue Oct 25, 2021 · 2 comments
Closed

Write resolved sdk version to output variable #241

MeikTranel opened this issue Oct 25, 2021 · 2 comments
Assignees
Labels
feature request New feature or request to improve the current logic

Comments

@MeikTranel
Copy link

Description:
Once an SDK version is installed the action should set an output variable where one can read the version installed for reuse.

Justification:
Workspaces with global.json can skip providing a version to the setup-dotnet action. But when you write more complex workflows with multiple jobs you dont always want to checkout the repository to have that global.json available. I'd like to have a resolved version available once the setup has been run during an initial build job.

Are you willing to submit a PR?

Sure - Should be a simple addition to the action.yml and two lines in index.js 😂

@MeikTranel MeikTranel added feature request New feature or request to improve the current logic needs triage labels Oct 25, 2021
@vsafonkin
Copy link

vsafonkin commented Nov 1, 2021

Hi @MeikTranel, in case of multiple jobs you should pass the value of this output variable to every job because every job is running on the new runner. From my point of view, there is no advantage between getting version from some output variable instead global.json file and if the global.json file is available in initial build job, it should be available in other jobs. With using additional variable implicit logic arises for getting version. I would rather not make such changes. Please, correct me if I misunderstood something.

@IvanZosimov
Copy link
Contributor

Hi, @MeikTranel 👋 The functionality you asked for was implemented in the new v3 version of setup-dotnet action. By now I'm going to close this issue, If you have any additions or questions feel free to ping us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request to improve the current logic
Projects
None yet
Development

No branches or pull requests

3 participants