From b89bdda037b5b1146f1852a0f477c6e7f6495fe8 Mon Sep 17 00:00:00 2001 From: eric sciple Date: Sat, 16 May 2020 13:57:23 -0400 Subject: [PATCH] switch GITHUB_URL to GITHUB_SERVER_URL --- src/Runner.Plugins/Repository/v1.0/GitSourceProvider.cs | 2 +- src/Runner.Worker/GitHubContext.cs | 2 +- src/Runner.Worker/JobExtension.cs | 5 +++-- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/src/Runner.Plugins/Repository/v1.0/GitSourceProvider.cs b/src/Runner.Plugins/Repository/v1.0/GitSourceProvider.cs index 5c83accce07..5f776723ce1 100644 --- a/src/Runner.Plugins/Repository/v1.0/GitSourceProvider.cs +++ b/src/Runner.Plugins/Repository/v1.0/GitSourceProvider.cs @@ -82,7 +82,7 @@ private string GenerateBasicAuthHeader(RunnerActionPluginExecutionContext execut executionContext.Output($"Syncing repository: {repoFullName}"); // Repository URL - var githubUrl = executionContext.GetGitHubContext("url"); + var githubUrl = executionContext.GetGitHubContext("server_url"); var githubUri = new Uri(!string.IsNullOrEmpty(githubUrl) ? githubUrl : "https://github.com"); var portInfo = githubUri.IsDefaultPort ? string.Empty : $":{githubUri.Port}"; Uri repositoryUrl = new Uri($"{githubUri.Scheme}://{githubUri.Host}{portInfo}/{repoFullName}"); diff --git a/src/Runner.Worker/GitHubContext.cs b/src/Runner.Worker/GitHubContext.cs index afc08708902..ac6566ad919 100644 --- a/src/Runner.Worker/GitHubContext.cs +++ b/src/Runner.Worker/GitHubContext.cs @@ -22,8 +22,8 @@ public sealed class GitHubContext : DictionaryContextData, IEnvironmentContextDa "repository_owner", "run_id", "run_number", + "server_url", "sha", - "url", "workflow", "workspace", }; diff --git a/src/Runner.Worker/JobExtension.cs b/src/Runner.Worker/JobExtension.cs index 02745013c1f..235cc90638e 100644 --- a/src/Runner.Worker/JobExtension.cs +++ b/src/Runner.Worker/JobExtension.cs @@ -131,12 +131,13 @@ public async Task> InitializeJob(IExecutionContext jobContext, Pipel // Temporary hack for GHES alpha var configurationStore = HostContext.GetService(); var runnerSettings = configurationStore.GetSettings(); - if (string.IsNullOrEmpty(context.GetGitHubContext("url")) && !runnerSettings.IsHostedServer && !string.IsNullOrEmpty(runnerSettings.GitHubUrl)) + if (string.IsNullOrEmpty(context.GetGitHubContext("server_url")) && !runnerSettings.IsHostedServer && !string.IsNullOrEmpty(runnerSettings.GitHubUrl)) { var url = new Uri(runnerSettings.GitHubUrl); var portInfo = url.IsDefaultPort ? string.Empty : $":{url.Port.ToString(CultureInfo.InvariantCulture)}"; - context.SetGitHubContext("url", $"{url.Scheme}://{url.Host}{portInfo}"); + context.SetGitHubContext("server_url", $"{url.Scheme}://{url.Host}{portInfo}"); context.SetGitHubContext("api_url", $"{url.Scheme}://{url.Host}{portInfo}/api/v3"); + context.SetGitHubContext("graphql_url", $"{url.Scheme}://{url.Host}{portInfo}/api/graphql"); } // Evaluate the job-level environment variables