Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update/Add RVM #5

Closed
3 of 5 tasks
scottohara opened this issue Oct 1, 2019 · 4 comments
Closed
3 of 5 tasks

Update/Add RVM #5

scottohara opened this issue Oct 1, 2019 · 4 comments

Comments

@scottohara
Copy link

Tool information

  • Tool name: RVM
  • Add or update? Add
  • Desired version: latest
  • Approximate size:
  • If this is an add request:
    • Brief description of tool: install/switch between Ruby versions, auto-installs & uses the ruby version as specified in a project’s .ruby-version file
    • URL for tool's homepage: https://rvm.io

Virtual environments affected

  • macOS 10.14
  • Ubuntu 16.04 LTS
  • Ubuntu 18.04 LTS
  • Windows Server 2016 R2
  • Windows Server 2019

Can this tool be installed during the build?

Yes, but not easily. See https://github.community/t5/GitHub-Actions/How-to-share-shell-profile-between-steps-or-how-to-use-nvm-rvm/td-p/33185

Are you willing to submit a PR?
@kaylangan
Copy link
Contributor

👋 Thanks for the suggestion! Is there something that RVM does that isn't possible with the actions/setup-node action?

@scottohara
Copy link
Author

Same reasoning as per #4 (comment)

@eregon
Copy link

eregon commented Jan 12, 2020

This seems overkill just for getting the version from .ruby-version.
I think it's better to support reading from .ruby-version in setup-ruby, and I see you filed actions/setup-ruby#31

Is there any other reason to add RVM here? Otherwise I'd suggest to close this.

@scottohara
Copy link
Author

Happy for this to be closed in favour of setup-ruby support for installing the version of ruby specified in .ruby-version.

alepauly pushed a commit that referenced this issue Jan 13, 2020
@vmapetr
Toolcache: Rework linux toolcache tests, add Ruby 2.7.0 support (#5)
9c67ed5 
* Toolcache: rework linux toolcache tests

* Toolcache: add Ruby 2.7 for windows/linux
alepauly pushed a commit that referenced this issue Apr 24, 2020
@andy-mishechkin
Merge pull request #5 from actions/master
5106c27 
Get the last changes from master to my fork
maxim-lobanov pushed a commit that referenced this issue Jul 8, 2020
@dibir-magomedsaygitov
Merge pull request #5 from actions/master
5f43f05 
update local enviroonment
maxim-lobanov pushed a commit that referenced this issue Jul 20, 2020
@al-cheb
Replace current validates with pester testing approach #5 (#1232)
0c4dca2 
* ,oving to the pester approach part #5

* moving to the pester approach part #5

* fixed PostgreSQL tests

* return Validate-Svn.ps1

* fixed Selenium test

* fixed rust test

* fix rust test
@hartwork hartwork mentioned this issue Dec 16, 2021
Closed
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@eregon @scottohara @kaylangan