Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README to use pull_request_target event #90

Merged
merged 1 commit into from
Sep 8, 2020
Merged

Update README to use pull_request_target event #90

merged 1 commit into from
Sep 8, 2020

Conversation

ylemkimon
Copy link
Contributor

GitHub has introduced a new event type: pull_request_target, which allows to run workflows from base branch and pass a token with write permission.

In order to solve this, we’ve added a new pull_request_target event, which behaves in an almost identical way to the pull_request event with the same set of filters and payload. However, instead of running against the workflow and code from the merge commit, the event runs against the workflow and code from the base of the pull request. This means the workflow is running from a trusted source and is given access to a read/write token as well as secrets enabling the maintainer to safely comment on or label a pull request. This event can be used in combination with the private repository settings as well.

@dakale
Copy link
Contributor

dakale commented Sep 8, 2020

LGTM, thanks for this!

@dakale dakale merged commit c45f41c into actions:main Sep 8, 2020
@zvecr zvecr mentioned this pull request Oct 19, 2020
Merged
14 tasks
shogo82148 added a commit to shogo82148/docs that referenced this pull request Mar 14, 2021
@shogo82148
fix an example in authentication-in-a-workflow
3c33295 
actions/labeler now recommends to use the `pull_request_target` event.
With the `pull_request` event, `GITHUB_TOKEN` sometimes lacks write permissions (e.g. pull requests from forked repository or from dependabot)
and actions/labeler doesn't work well.

ref. actions/labeler#90
ref. https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks
@shogo82148 shogo82148 mentioned this pull request Mar 14, 2021
Merged
3 tasks
@dependabot dependabot bot mentioned this pull request Mar 17, 2021
Merged
@damccorm damccorm mentioned this pull request Jan 31, 2022
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ylemkimon @dakale