Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumping actions/core and actions/github dependencies for GHES #69

Merged
merged 6 commits into from
May 12, 2020

Conversation

pjquirk
Copy link
Contributor

@pjquirk pjquirk commented May 8, 2020

This adds support for running against GHES by using v2.2.0 of @actions/github. I also bumped @actions/core to 1.2.4 to fix error handling in the case an Error type is thrown rather than a string.

The build/pack steps seemed unreliable, so I updated the Typscript config to build to ./lib, and ncc will then build out of that (this matches other actions like actions/stale).

Tested by pushing this version of the action to an "actions" org on the GHES instance. I also needed to set NODE_TLS_REJECT_UNAUTHORIZED = 0 temporarily in the action to get around my self-signed (or otherwise not trusted) server cert.

@pjquirk pjquirk changed the title Bumping actions/github to 2.2.0 Bumping actions/core and actions/github dependencies for GHES May 12, 2020
@pjquirk pjquirk requested review from dakale and ericsciple May 12, 2020 18:43
lib/main.js Outdated Show resolved Hide resolved
@dakale
Copy link
Contributor

dakale commented May 12, 2020

What is the benefit of changing from dist/index to lib/index? Not sure I understand the point, or why the lib/ file is so much smaller than the dist/ one...

@pjquirk
Copy link
Contributor Author

pjquirk commented May 12, 2020

@dakale It's mainly to distinguish the outputs of tsc (lib) and the outputs of ncc (dist). It doesn't make sense to put them both into the same folder, like it was before. dist should have one file in it, index.js.

@dakale
Copy link
Contributor

dakale commented May 12, 2020

Thanks, that makes sense, as does ignoring checking in lib/

@dakale
Copy link
Contributor

dakale commented May 12, 2020

(I can merge if you dont have permission)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants