This repository has been archived by the owner on May 3, 2022. It is now read-only.
Fix missing proxy auth #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changes look good. I think you need to run format on the code so the prettier check passes (it only runs on the linux leg - see the failed run) |
fgalind1
reviewed
Mar 24, 2021
Co-authored-by: Felipe Galindo Sanchez <felipe.galindo.sanchez@intel.com>
This was referenced Apr 5, 2021
jen801
reviewed
Mar 20, 2022
| @@ -2,6 +2,7 @@ import * as http from 'http' | |||
| import * as httpm from '../_out' | |||
| import * as pm from '../_out/proxy' | |||
| import * as proxy from 'proxy' | |||
jen801
reviewed
Mar 20, 2022
| @@ -2,6 +2,7 @@ import * as http from 'http' | |||
| import * as httpm from '../_out' | |||
| import * as pm from '../_out/proxy' | |||
| import * as proxy from 'proxy' | |||
| import * as tunnelm from 'tunnel' | |||
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #39 by adding check to see whether proxy authentication is provided