Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to the latest version of Octokit #193

Merged
merged 3 commits into from Sep 24, 2021
Merged

Upgrade to the latest version of Octokit #193

merged 3 commits into from Sep 24, 2021

Conversation

joshmgross
Copy link
Member

Supports #133, #155, #179
This updates the github authenticated Octokit client available in this action to version 5 of the Octokit client. This change allows users to script using the latest released API.

Since this is a major version update and includes breaking changes, this will come with a v5 release of this action.

The primary breaking change is that REST methods must use github.rest.* instead of github.*. I've added a note to the README for this change and updated our examples.

@joshmgross joshmgross requested a review from a team as a code owner September 23, 2021 21:20
@github-actions
Copy link

Hello from actions/github-script! (05e1495)

Copy link

@hashtagchris hashtagchris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

"@actions/github": "^4.0.0",
"@actions/glob": "^0.1.2",
"@actions/github": "^5.0.0",
"@actions/glob": "^0.2.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why didn't we move to 0.2.0 in #192?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran npm i @actions/glob to create #192, which I thought would bump minor versions but I think 0.y.z has special meaning in semver so it did not bump to the "latest minor version".

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

https://semver.org/#spec-item-4

Copy link

@Echo4F Echo4F left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants