Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update @octokit/plugin-rest-endpoint-methods to version 6.x #283

Merged
merged 4 commits into from
Aug 26, 2022

Conversation

desrosj
Copy link
Contributor

@desrosj desrosj commented Aug 18, 2022

This updates the dependency to the latest version within current SemVer constraints.

v5.14.0 specifically includes a number of new endpoints, including .rest.actions.reRunWorkflowFailedJobs(), which is the one I am trying to use when discovering this issue. Currently the following error is given:

Error: Unhandled error: TypeError: github.rest.actions.reRunWorkflowFailedJobs is not a function

This updates the dependency to the latest version within current SemVer constraints.
@desrosj desrosj requested a review from a team as a code owner August 18, 2022 17:52
@desrosj
Copy link
Contributor Author

desrosj commented Aug 18, 2022

There is a v16.0.0, however this version drops support for NodeJS v10 & v12. Happy to update this PR if these versions are no longer supported.

@joshmgross
Copy link
Member

Happy to update this PR if these versions are no longer supported.

The latest version of this action is using Node 16, so I'm good with updating to the latest version

https://github.com/actions/github-script/blob/main/action.yml#L29-L30

@desrosj desrosj changed the title Update @octokit/plugin-rest-endpoint-methods. Update @octokit/plugin-rest-endpoint-methods to version 6.x Aug 25, 2022
@desrosj
Copy link
Contributor Author

desrosj commented Aug 25, 2022

I've updated the version to the latest (v6.3.0).

I also noticed that the version numbers in the package.json and package-lock.json files were not updated for versions 6.1 and 6.1.1. I bumped these to values to 6.2.0 to make it easier to tag the next release after this PR is merged.

Copy link
Member

@joshmgross joshmgross left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this!

I can push changes to update the licenses.

Since the only breaking changes are dropping support for Node 10 and 12 which won't affect this action, I don't think we need a major version bump to v7 for actions/github-script

@joshmgross joshmgross merged commit c713e51 into actions:main Aug 26, 2022
@joshmgross
Copy link
Member

Available in https://github.com/actions/github-script/releases/tag/v6.2.0

@desrosj desrosj deleted the update/plugin-rest-endpoint-methods branch August 26, 2022 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants