Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error count #186

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

Error count #186

wants to merge 5 commits into from

Conversation

GretaP
Copy link
Contributor

@GretaP GretaP commented Jun 14, 2023

Copy link
Contributor

@JamesMGreene JamesMGreene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be ideal to also get a test in place for actually verifying that Deployment#maxErrorCount eventually gets honored during error scenarios, but this PR is already an improvement either way. 💖

If that is something we can successfully add without spending more than, say, an hour on it, that would be a win. If not, I wouldn't consider that to be a blocker. 🤷🏻‍♂️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add sanitization, validation, and basic tests for the error_count input parameter
2 participants