Enable setting configuration options for local testing #290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cnagadya
changed the title
cnagadya
changed the title
febuiles
reviewed
Oct 17, 2022
febuiles
reviewed
Oct 17, 2022
|
Validation:
With an external config file:
|
|
@cnagadya please take a look and let me know what you think! |
cnagadya
commented
Oct 24, 2022
cnagadya
commented
Oct 24, 2022
|
Looks great. Just two small ( |
Co-authored-by: cnagadya <cnagadya@github.com>
Co-authored-by: cnagadya <cnagadya@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds ability to set configuration options via dev-config.yml
PS: With modification of CONTRIBUTING.md to update instructions, there are some linter changes included in this PR