Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GH Licenses API to retrieve null licenses #284

Merged
merged 5 commits into from Oct 13, 2022
Merged

Conversation

cnagadya
Copy link
Contributor

@cnagadya cnagadya commented Oct 12, 2022

Resolves #1492

In the Action, if the license for a valid dependency change retrieved is from Dependency Review API is null, it is then retrieved from GitHub Licenses API if it exists.

cnagadya and others added 3 commits October 13, 2022 11:03
Co-authored-by: Henri Maurer <hmaurer@github.com>
Co-authored-by: Federico Builes <febuiles@github.com>
@cnagadya cnagadya marked this pull request as ready for review October 13, 2022 12:03
@cnagadya cnagadya requested a review from a team as a code owner October 13, 2022 12:03
Mocks are removed in Jest automatically due to our
Jest config file.

Co-authored-by: Christine Nagadya <cnagadya@github.com>
Co-authored-by: Henri Maurer <hmaurer@github.com>
@febuiles febuiles merged commit f7d03d8 into main Oct 13, 2022
@febuiles febuiles deleted the cn/license-api-fallback branch October 13, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants