New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add external configuration file #228
Conversation
# Conflicts: # README.md # __tests__/config.test.ts # dist/index.js.map # src/config.ts # src/schemas.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌🏽 looks great, this is going to be so useful!!
// pass inline options in the presence of an external config file. | ||
const inlineConfig = readInlineConfig() | ||
// the external config takes precedence | ||
return Object.assign({}, inlineConfig, config) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about Object.assign
, nicee.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@febuiles A bit of a late reply, but there's spread syntax: https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Operators/Spread_syntax.
Co-authored-by: Sarah Aladetan <sarahkemi@github.com>
We are bringing back the behavior from #91 where users can customize the action through an external configuration file.
Acceptance Criteria