Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support user-provided base/head refs & non-PR workflows #200

Merged
merged 4 commits into from Aug 18, 2022

Conversation

febuiles
Copy link
Contributor

@WillDaSilva apologies, I closed #165 by mistakenly changing the merge HEAD to this branch in order to be able to push some minor changes.

Do you have a sample workflow file we could use to showcase the behavior in the README and Release Notes?

@febuiles febuiles requested a review from a team as a code owner August 18, 2022 13:28
@febuiles febuiles merged commit 9f2f2d8 into main Aug 18, 2022
@WillDaSilva
Copy link
Contributor

Do you have a sample workflow file we could use to showcase the behavior in the README and Release Notes?

@febuiles Not exactly. At Meltano we've been using my fork of this action for 25 days now, and haven't run into any problems: https://github.com/meltano/meltano/blame/6de7c109b89dd1c0e7ace993d2934a51c4fb7867/.github/workflows/dependency-review.yml#L28

We only needed it to run the action for pull_request_target events though, so we aren't testing out setting a custom head-ref and base-ref. We could do so to support running that step of the workflow on workflow_dispatch events, but that might be a bit confusing since the following step of the workflow would still only run for the checked out ref.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants