Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore removed changes in license checker #155

Merged
merged 3 commits into from Jul 14, 2022
Merged

Conversation

kachick
Copy link
Contributor

@kachick kachick commented Jul 13, 2022

Fixes #154

gh api \
  -H "Accept: application/vnd.github+json" \
  /repos/fastify/fastify-passport/dependency-graph/compare/4b912074ad2273172b65eb44e52201e37583226e...62bdea61e7c137028263b59943de4e65583db760 | jq '.[] | select(.name == "string-similarity")'
{
  "change_type": "removed",
  "manifest": "package-lock.json",
  "ecosystem": "npm",
  "name": "string-similarity",
  "version": "4.0.4",
  "package_url": "pkg:npm/string-similarity@4.0.4",
  "license": "ISC AND MIT",
  "source_repository_url": "https://github.com/aceakash/string-similarity",
  "vulnerabilities": []
}

@kachick kachick requested a review from a team as a code owner July 13, 2022 09:12
Copy link
Contributor

@febuiles febuiles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for this @kachick ❤️

__tests__/licenses.test.ts Show resolved Hide resolved
@febuiles febuiles merged commit 1dc503a into actions:main Jul 14, 2022
@kachick
Copy link
Contributor Author

kachick commented Jul 14, 2022

Thank you for your reviewing and merging!

@kachick kachick deleted the fix-154 branch July 14, 2022 07:18
kachick added a commit to kachick/dependency-review-action that referenced this pull request Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Action throws error when removing dependency with disallowed license
2 participants